reduce blocking HTTP requests during authentication #22292
Annotations
4 errors and 1 warning
Run google-github-actions/auth@v0
The v0 series of google-github-actions/auth is no longer maintained. It will not receive updates, improvements, or security patches. Please upgrade to the latest supported versions:
https://github.com/google-github-actions/auth
|
Run google-github-actions/setup-gcloud@v0
The v0 series of google-github-actions/setup-gcloud is no longer maintained. It will not receive updates, improvements, or security patches. Please upgrade to the latest supported versions:
https://github.com/google-github-actions/setup-gcloud
|
Run pnpm run test:unit --run:
vscode/src/jsonrpc/protocol.test.ts#L62
AssertionError: Invalid protocol definitions: 1 problems.
Problem: If a property's type includes any of `null`, `undefined`, or `?` (optional field), then it must use *all* of them.
Fix: Use `field?: T | null | undefined` instead of `field?: T`.
Explanation: To prevent bugs when communicating with peers implemented in different programming languages cross-process RPC protocols must not differentiate between `undefined`, ECMAScript property presence (`hasOwnProperty`), and `null`.
Anywhere that a value can be `undefined`, our code needs to handle `null` values or no such property existing, and all must be handled in the same way (and vice versa).
vscode/src/chat/protocol.ts:141:11: property "userProductSubscription" type must accept null, undefined, and optional ("userProductSubscription?: T | undefined | null")
❯ src/jsonrpc/protocol.test.ts:62:20
|
Run pnpm run test:unit --run
Process completed with exit code 1.
|
The following actions use a deprecated Node.js version and will be forced to run on node20: google-github-actions/auth@v0, google-github-actions/setup-gcloud@v0. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Loading