E2E: ensure input boxes are visible before filling in auth (#4798)

sourcegraph · Jul 5, 2024 · c2a15de · c2a15de
1 parent 6b5032a
commit c2a15de
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/vscode/test/e2e/chat-history.test.ts b/vscode/test/e2e/chat-history.test.ts
@@ -26,6 +26,9 @@ test.extend<ExpectedV2Events>({
 
     const [chatPanelFrame, chatInput] = await createEmptyChatPanel(page)
 
+    // Ensure the chat view is ready before we start typing
+    await expect(chatPanelFrame.getByText('to add context to your chat')).toBeVisible()
+
     await chatInput.fill('Hey')
     await chatInput.press('Enter')
 

diff --git a/vscode/test/e2e/common.ts b/vscode/test/e2e/common.ts
@@ -15,8 +15,11 @@ export const sidebarSignin = async (
     await focusSidebar(page)
     await sidebar.getByRole('button', { name: 'Sign In to Your Enterprise Instance' }).click()
     await page.getByRole('option', { name: 'Sign In with URL and Access Token' }).click()
+    // Ensure the correct input box has showed up before we start filling in the forms.
+    await expect(page.getByText('Enter the URL of the')).toBeVisible()
     await page.getByRole('combobox', { name: 'input' }).fill(SERVER_URL)
     await page.getByRole('combobox', { name: 'input' }).press('Enter')
+    await expect(page.getByText('Paste your access token')).toBeVisible()
     await page.getByRole('combobox', { name: 'input' }).fill(VALID_TOKEN)
     await page.getByRole('combobox', { name: 'input' }).press('Enter')