pass config to webview through new Observable-based webview API #5751
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The webview protocol message
config
had 2 problems:ChatController.sendConfig
) whenever ChatController thought it might have changed, which meant a bunch of unnecessary calls tosendConfig
sprinkled throughout ChatController.configFeatures
and other things having custom logic to construct them in ChatController.This solves problem 1. Now, the config is sent through the
legacyConfig(): LegacyWebviewConfig
observable webview API method to the webview, which means it gets an up-to-date view of the config. It uses the same type, so this does not yet address problem 2, but it makes it much easier to address it.Removes the old
config
webview protocol message.There is no user-facing behavior change.
Test plan
CI and e2e