Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete: re-enable agent tests #5784

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Conversation

valerybugakov
Copy link
Member

@valerybugakov valerybugakov commented Oct 3, 2024

  • No functional changes.
  • 90% of the diff are recordings and bindings updates 🙂
  • Re-enabled existing autocomplete integration tests and improved the stability of recoding updates. Initially, they were disabled here: Agent: update access token for integration tests #5629
  • Replaced most of the sleep calls with new agent testing/X requests to await for a timeout in question (Slack thread).
  • Removed the NoopCompletionItemProvider registration for unauthenticated users to fix the flaky behavior where the real autocomplete provider was not registered before the first autocomplete/execute call in tests (Slack thread). Autocomplete is currently available only for authenticated requests, so this change should not have any functional side effects.
  • Updated Kotlin bindings (some are not related to this PR, but AFAIK, this is caused by the main branch not being updated).
  • Part of https://linear.app/sourcegraph/issue/CODY-3910/add-autocomplete-integation-tests-for-server-side-model-config

Test plan

CI and pnpm vitest agent/src/autocomplete.test.ts

@valerybugakov valerybugakov marked this pull request as ready for review October 3, 2024 13:28
@valerybugakov valerybugakov requested a review from sqs October 3, 2024 23:56
Copy link
Member

@sqs sqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, great to get these enabled again. Thanks!

@valerybugakov valerybugakov enabled auto-merge (squash) October 4, 2024 02:14
@valerybugakov valerybugakov merged commit b055686 into main Oct 4, 2024
18 checks passed
@valerybugakov valerybugakov deleted the vb/autocomplete-agent-tests branch October 4, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants