Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Segmentation catalog to increase source detection #1630

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mdlpstsci
Copy link
Collaborator

@mdlpstsci mdlpstsci commented Jul 31, 2023

Changes associated with Jira HLA-1004.

Changed the variable names for the general "biggest source" and "biggest source fraction" limits which were misleading, and added a new variable name to accommodate the RickerWavelet biggest source limit.
OLD NEW
_rw2d_biggest_source ==> _biggest_source_limit
_rw2d_source_fraction ==> _biggest_source_fraction_limit
new ==> _rw_biggest_source_limit

These changes required updating the catalog parameter JSON files, the code which reads the parameter values, and parameter names in segmentation source support functions.

Clarified informational log messages when reporting the configuration limits in use for the Segmentation catalog. Moved the computation of the ratio between the "Gaussian biggest source" and the "Rickerwavlet biggest source" to be computed, as well as applied, for Round 2. Added more informational messages to keep the user better informed. Changed some limit values (though more changes will be needed for other detectors):

ACS/WFC ONLY
negative_percent: 15.0 ==> 20.0
rw2d_nsigma: 10.0 ==> 40.0

@mdlpstsci mdlpstsci added enhancement jirahub-ignore Avoid linking to Jira labels Jul 31, 2023
@mdlpstsci mdlpstsci self-assigned this Jul 31, 2023
@mdlpstsci mdlpstsci requested a review from a team as a code owner July 31, 2023 12:41
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage is 86.36% of modified lines.

Files Changed Coverage
drizzlepac/haputils/catalog_utils.py 86.36%

📢 Thoughts on this report? Let us know!.

…est source fraction"

limits which were misleading, and added a new variable name to accommodate the RickerWavelet
biggest source limit.
   OLD                       NEW
   _rw2d_biggest_source  ==> _biggest_source_limit
   _rw2d_source_fraction ==> _biggest_source_fraction_limit
    new                  ==> _rw_biggest_source_limit

These changes required updating the catalog parameter JSON files, the code which reads
the parameter values, and parameter names in segmentation source support functions.

Clarified informational log messages when reporting the configuration limits in use for
the Segmentation catalog.  Moved the computation of the ratio between the "Gaussian
biggest source" and the "Rickerwavlet biggest source" to be computed, as well as applied,
for Round 2. Added more informational messages to keep the user better informed.  Changed
some limit values (though more changes will be needed for other detectors):

ACS/WFC ONLY
   negative_percent: 15.0 ==> 20.0
   rw2d_nsigma: 10.0  ==> 40.0
@mdlpstsci mdlpstsci added the Do Not Merge PR which should not be merged label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge PR which should not be merged enhancement jirahub-ignore Avoid linking to Jira testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants