Open json files as ModelLibrary if romancal is installed
#389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
- Coverage 97.56% 97.42% -0.14%
==========================================
Files 30 37 +7
Lines 2788 3380 +592
==========================================
+ Hits 2720 3293 +573
- Misses 68 87 +19 ☔ View full report in Codecov by Sentry. |
braingram
force-pushed
the
open_asn
branch
8 times, most recently
from
4bc5276
to
7ac9fa6
Compare
braingram
changed the title
json files as ModelLibrary if romancal is installed
braingram
force-pushed
the
open_asn
branch
4 times, most recently
from
99aa08a
to
ad3e5db
Compare
PaulHuwe
approved these changes
Sep 25, 2024
| pytest-cov | ||
| commands_pre = | ||
| bash -c "pip freeze -q | grep 'roman_datamodels @' > {env_tmp_dir}/requirements.txt" | ||
| pip install git+https://github.com/spacetelescope/romancal.git |
There was a problem hiding this comment.
My only question is if this should be against the dev version or the last stable version? dev feels right, but I want to make sure you agree.
There was a problem hiding this comment.
I agree I think dev is most useful here since the versions tend to march along together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #267
As discussed in the issue, roman_datamodels by itself cannot open an association. So if a user provides an association to
roman_datamodels.openwe could:This PR takes the second approach. Adding support to open
.jsonfiles provided todatamodels.openasModelLibraryinstances (ifromancalis installed).This required added a new CI job
with_romancalwhich currently only runs the one unit test for this feature.Regtests show same failures as main: https://github.com/spacetelescope/RegressionTests/actions/runs/11000547719
Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)romancalregression test with this branch installed ("git+https://github.com/<fork>/roman_datamodels@<branch>")news fragment change types...
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change