Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow encryptors other than authlogic_sha512 #295

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tristanm
Copy link

Implements :encryptor config option which allows developers to set encryptors other than just authlogic_512. Any encryptor from Devise Encryptable should be able to be used, including custom encryptors, although I have only tested authlogic_512 and bcrypt.

The default has been left as authlogic_512 to remain compatible with existing apps. However, all specs pass when the default is changed to bcrypt.

Specs only check for the inclusion (or not) of Devise::Models::Encryptable and the value of Devise::Models::Encryptable#encryptor. I figure any other functional tests to do with the encryptors belong with the encryptors themselves in Devise. That said, let me know if there's anything else which needs to be tested.

Any higher makes tests intolerably slow when using bcrypt.
- Creates an encryptor preference.
- Only includes Devise::Models::Encryptable if bcrypt is not used.
@tristanm
Copy link
Author

Travis is failing because mysql2 isn't in Gemfile... anything I should do for this?

@kushniryb
Copy link
Contributor

@tristanm Pease rebase against current master, thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants