-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change unset-memory-requirements check #695
Comments
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 26, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 26, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 26, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 26, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 26, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 27, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 27, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 27, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 27, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 27, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 27, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the
unset-memory-requirements
requires both requests and limits. This is redundant as request if not set will be copied from limits. The memory differs from CPU as with not enough CPU the container will slow down while with missing memory it will be killed. That's why requirements and limits should be set to same value.The change should happen in check template definition
requirementsType: "any"
@test "unset-memory-requirements" {
kube-linter/pkg/builtinchecks/yamls/unset-memory-requirements.yaml
Line 11 in 24d1fe3
As well as in the related tests:
kube-linter/e2etests/bats-tests.sh
Line 916 in e68f7d1
The text was updated successfully, but these errors were encountered: