Update unset-memory-requirements and unset-cpu-requirements #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgalek
force-pushed
the
unset-cpu-and-unset-memory-fix
branch
3 times, most recently
from
07f4b1c
to
5196c76
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #734 +/- ##
=======================================
Coverage 72.37% 72.37%
=======================================
Files 45 45
Lines 1937 1937
=======================================
Hits 1402 1402
Misses 421 421
Partials 114 114
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bgalek
force-pushed
the
unset-cpu-and-unset-memory-fix
branch
3 times, most recently
from
42f662e
to
375cee6
Compare
janisz
requested changes
Feb 27, 2024
README.md
Outdated
There was a problem hiding this comment.
I like the idea of splitting long lines but please do it in a separated PR. Ideally we should have a CI check to prevent long lines in the future.
bgalek
force-pushed
the
unset-cpu-and-unset-memory-fix
branch
5 times, most recently
from
3c9a47c
to
59dba1e
Compare
bgalek
force-pushed
the
unset-cpu-and-unset-memory-fix
branch
from
59dba1e
to
fc6e385
Compare
Signed-off-by: Tomasz Janiszewski <[email protected]>
janisz
approved these changes
Feb 27, 2024
|
@bgalek Thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Happy to fix #694 #695!