feat: (try) Support u384 numeric literals #6146
Open
+40
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
u384 takes 4-5 lines to write as constant or in tests, so this would improve a lot readability and dev experience
Currently i've added
circuits.cairo
circuit_test.cairo
validate_literal
incrates/cairo-lang-semantic/src/corelib.rs
for the typevalue_as_const_value
incrates/cairo-lang-semantic/src/items/constant.rs
to split the limbs for the typeHowever when running
./scripts/cairo_test.sh
the issue is thatget_core_ty_by_name(db, "u384".into(), vec![])
says thatu384
doesn't exist (Unknown type
)Would appreciate some help from this point. Thank you!
This change is