fixed a bug where the trait of trait impl were not substituted correc… #6430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerStarkware
force-pushed
the
tomer/fixed_trait_impl_usage_substitution
branch
from
91d3c50
to
3e993a2
Compare
orizi
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)
crates/cairo-lang-semantic/src/items/tests/trait_impl line 1207 at r1 (raw file):
//! > ========================================================================== //! > Passing as an argument a Trait impl of generic trait where the generic argument is a generic type.
shorten name.
Code quote:
Passing as an argument a Trait impl of generic trait where the generic argument is a generic type.
…tly when it is used as a generic argument
TomerStarkware
force-pushed
the
tomer/fixed_trait_impl_usage_substitution
branch
from
3e993a2
to
4466632
Compare
TomerStarkware
commented
Sep 30, 2024
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-semantic/src/items/tests/trait_impl line 1207 at r1 (raw file):
Previously, orizi wrote…
shorten name.
Done.
orizi
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tly when it is used as a generic argument
This change is