Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mempool_test_util): rename constructor #1123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

giladchase
Copy link
Contributor

@giladchase giladchase commented Oct 1, 2024

This constructor name hints better that its only useful for accounts.


This change is Reviewable

This constructor name hints better that its only useful for accounts.
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.62%. Comparing base (b0cfe82) to head (d6b8119).
Report is 205 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (d6b8119). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b0cfe82) HEAD (d6b8119)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1123       +/-   ##
===========================================
- Coverage   74.18%   14.62%   -59.57%     
===========================================
  Files         359       32      -327     
  Lines       36240     2783    -33457     
  Branches    36240     2783    -33457     
===========================================
- Hits        26886      407    -26479     
+ Misses       7220     2356     -4864     
+ Partials     2134       20     -2114     
Flag Coverage Δ
14.62% <ø> (-59.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ayeletstarkware ayeletstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @elintul)

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants