Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(network): rename BroadcastedMessageManager to BroadcastedMessageMetadata #1144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShahakShama
Copy link
Contributor

@ShahakShama ShahakShama commented Oct 1, 2024

This change is Reviewable

Copy link
Contributor

@matan-starkware matan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

@ShahakShama ShahakShama force-pushed the shahak/rename_BroadcastedMessageManager branch from 80780ac to c8b28ff Compare October 1, 2024 13:45
@ShahakShama ShahakShama force-pushed the shahak/rename_BroadcastedMessageManager branch from c8b28ff to 0d39239 Compare October 1, 2024 14:04
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 30.90%. Comparing base (b0cfe82) to head (0d39239).
Report is 201 commits behind head on main.

Files with missing lines Patch % Lines
crates/papyrus_network/src/network_manager/mod.rs 66.66% 1 Missing and 1 partial ⚠️
crates/mempool_p2p_types/src/communication.rs 0.00% 1 Missing ⚠️
...papyrus_network/src/network_manager/swarm_trait.rs 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (0d39239). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b0cfe82) HEAD (0d39239)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1144       +/-   ##
===========================================
- Coverage   74.18%   30.90%   -43.29%     
===========================================
  Files         359       81      -278     
  Lines       36240     9203    -27037     
  Branches    36240     9203    -27037     
===========================================
- Hits        26886     2844    -24042     
+ Misses       7220     6245      -975     
+ Partials     2134      114     -2020     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants