Skip to content

Commit

Permalink
Add memory component.
Browse files Browse the repository at this point in the history
  • Loading branch information
alonh5 committed Jul 15, 2024
1 parent b1b93bc commit 63389ba
Show file tree
Hide file tree
Showing 3 changed files with 141 additions and 0 deletions.
139 changes: 139 additions & 0 deletions stwo_cairo_prover/src/components/memory/component.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,139 @@
use itertools::{zip_eq, Itertools};
use num_traits::Zero;
use stwo_prover::core::air::accumulation::PointEvaluationAccumulator;
use stwo_prover::core::air::mask::fixed_mask_points;
use stwo_prover::core::air::Component;
use stwo_prover::core::backend::CpuBackend;
use stwo_prover::core::circle::CirclePoint;
use stwo_prover::core::fields::m31::{BaseField, M31};
use stwo_prover::core::fields::qm31::SecureField;
use stwo_prover::core::fields::secure_column::SECURE_EXTENSION_DEGREE;
use stwo_prover::core::pcs::TreeVec;
use stwo_prover::core::poly::circle::{CanonicCoset, CircleEvaluation};
use stwo_prover::core::poly::BitReversedOrder;
use stwo_prover::core::{ColumnVec, InteractionElements, LookupValues};
use stwo_prover::trace_generation::registry::ComponentGenerationRegistry;
use stwo_prover::trace_generation::{ComponentGen, ComponentTraceGenerator};

const N_M31_IN_FELT252: usize = 21;
const LOG_MEMORY_ADDRESS_BOUND: usize = 24;
const MEMORY_ADDRESS_BOUND: usize = 1 << LOG_MEMORY_ADDRESS_BOUND;

/// Addresses are continuous and start from 0.
/// Values are Felt252 stored as N_M31_IN_FELT252 M31 values (each value contain 12 bits).
pub struct MemoryTraceGenerator {
// TODO(AlonH): Consider to change values to be Felt252.
pub values: Vec<[M31; N_M31_IN_FELT252]>,
pub multiplicities: Vec<u32>,
}

pub struct MemoryComponent {
pub log_n_instances: usize,
}

impl MemoryComponent {
pub fn n_columns(&self) -> usize {
N_M31_IN_FELT252 + 1
}
}

impl MemoryTraceGenerator {
pub fn new(_path: String) -> Self {
// TODO(AlonH): change to read from file.
let values = vec![[M31::zero(); N_M31_IN_FELT252]; MEMORY_ADDRESS_BOUND];
let multiplicities = vec![0; MEMORY_ADDRESS_BOUND];
Self {
values,
multiplicities,
}
}
}

impl ComponentGen for MemoryTraceGenerator {}

impl ComponentTraceGenerator<CpuBackend> for MemoryTraceGenerator {
type Component = MemoryComponent;
type Inputs = M31;

fn add_inputs(&mut self, inputs: &Self::Inputs) {
self.multiplicities[inputs.0 as usize] += 1;
}

fn write_trace(
component_id: &str,
registry: &mut ComponentGenerationRegistry,
) -> ColumnVec<CircleEvaluation<CpuBackend, BaseField, BitReversedOrder>> {
let memory_trace_generator = registry.get_generator::<MemoryTraceGenerator>(component_id);

let mut trace = vec![vec![BaseField::zero(); MEMORY_ADDRESS_BOUND]; N_M31_IN_FELT252 + 1];
for (i, (values, multiplicity)) in zip_eq(
&memory_trace_generator.values,
&memory_trace_generator.multiplicities,
)
.enumerate()
{
for (j, value) in values.iter().enumerate() {
trace[j][i] = BaseField::from_u32_unchecked(value.0);
}
trace[21][i] = BaseField::from_u32_unchecked(*multiplicity);
}

let domain = CanonicCoset::new(LOG_MEMORY_ADDRESS_BOUND as u32).circle_domain();
trace
.into_iter()
.map(|eval| CircleEvaluation::<CpuBackend, _, BitReversedOrder>::new(domain, eval))
.collect_vec()
}

fn component(&self) -> Self::Component {
MemoryComponent {
log_n_instances: LOG_MEMORY_ADDRESS_BOUND as usize,
}
}

fn write_interaction_trace(
&self,
_trace: &ColumnVec<&CircleEvaluation<CpuBackend, BaseField, BitReversedOrder>>,
_elements: &InteractionElements,
) -> ColumnVec<CircleEvaluation<CpuBackend, BaseField, BitReversedOrder>> {
todo!()
}
}

impl Component for MemoryComponent {
fn n_constraints(&self) -> usize {
3
}

fn max_constraint_log_degree_bound(&self) -> u32 {
LOG_MEMORY_ADDRESS_BOUND as u32 + 1
}

fn trace_log_degree_bounds(&self) -> TreeVec<ColumnVec<u32>> {
TreeVec::new(vec![
vec![self.log_n_instances as u32; self.n_columns()],
vec![self.log_n_instances as u32; SECURE_EXTENSION_DEGREE],
])
}

fn mask_points(
&self,
point: CirclePoint<SecureField>,
) -> TreeVec<ColumnVec<Vec<CirclePoint<SecureField>>>> {
TreeVec::new(vec![
fixed_mask_points(&vec![vec![0_usize]; self.n_columns()], point),
vec![vec![point]; SECURE_EXTENSION_DEGREE],
])
}

fn evaluate_constraint_quotients_at_point(
&self,
_point: CirclePoint<SecureField>,
_mask: &TreeVec<Vec<Vec<SecureField>>>,
_evaluation_accumulator: &mut PointEvaluationAccumulator,
_interaction_elements: &InteractionElements,
_lookup_values: &LookupValues,
) {
todo!()
}
}
1 change: 1 addition & 0 deletions stwo_cairo_prover/src/components/memory/mod.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
pub mod component;
1 change: 1 addition & 0 deletions stwo_cairo_prover/src/components/mod.rs
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
pub mod memory;
pub mod range_check_unit;

0 comments on commit 63389ba

Please sign in to comment.