Update stwo and fix changes.

[alonh5]

`

---

This change is 

[alonh5]

• Test memory trace. #27
• Get range check inputs one by one. #25
• Implement memory component prover. #24
• Write memory interaction trace. #23
• Add memory component. #19
• Evaluate constraints together. #18
• Add lookup step constraint. #17
• Add last lookup boundary constraint. #16
• Implement ComponentProver for RangeCheckUnitComponent. #13
• Implement Component for RangeCheckUnitComponent. #12
• Update stwo and fix changes. #11 👈
• Add rust format file. #14
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alonh5 and the rest of your teammates on Graphite

[shaharsamocha7]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @alonh5)

---

stwo_cairo_prover/src/components/range_check_unit.rs line 124 at r1 (raw file):

        let mut last = SecureField::zero();
        let interaction_values = zip_eq(&trace[0].values, &trace[1].values).fold(

Does it sum it in the bit_reverse order?

Also consider to rename

Suggestion:

let logup_values = zip_eq(&trace[0].values, &trace[1].values).fold(

---

stwo_cairo_prover/src/components/range_check_unit.rs line 126 at r1 (raw file):

        let interaction_values = zip_eq(&trace[0].values, &trace[1].values).fold(
            Vec::new(),
            |mut acc, (trace_value, multiplicity)| {

Rename

Suggestion:

|mut acc, (interaction_input, multiplicity)| {

---

stwo_cairo_prover/src/components/range_check_unit.rs line 127 at r1 (raw file):

            Vec::new(),
            |mut acc, (trace_value, multiplicity)| {
                let interaction_value = last + ((z - *trace_value).inverse() * *multiplicity);

Add a TODO to optimize this inverse

Code quote:

let interaction_value = last + ((z - *trace_value).inverse() * *multiplicity);

[alonh5]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7)

---

stwo_cairo_prover/src/components/range_check_unit.rs line 126 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Rename

Done.

---

stwo_cairo_prover/src/components/range_check_unit.rs line 127 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Add a TODO to optimize this inverse

It's simple I did it here.

[shaharsamocha7]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

[alonh5]

Merge activity

• Jul 11, 3:20 AM EDT: @alonh5 started a stack merge that includes this pull request via Graphite.
• Jul 11, 3:21 AM EDT: Graphite rebased this pull request as part of a merge.
• Jul 11, 3:23 AM EDT: @alonh5 merged this pull request with Graphite.