Make CommitmentSchemeProver::prove_values take ownership

[andrewmilson]

Simplifies the implementation of quotient commitment tree in following PR

This change is 

[andrewmilson]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Return opening positions and query positions per column size in FRI #856
• Make CommitmentSchemeProver::prove_values take ownership #852 👈
• Add arithmetic op counts to InfoEvaluator #832
• Add size estimate for StarkProof #831
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @andrewmilson and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 58.33333% with 15 lines in your changes missing coverage. Please review.

Project coverage is 91.95%. Comparing base (a46c994) to head (64b9479).

Files with missing lines	Patch %	Lines
crates/prover/src/core/prover/mod.rs	50.00%	11 Missing and 4 partials ⚠️

Additional details and impacted files

@@                                 Coverage Diff                                 @@
##           09-15-Add_arithmetic_op_counts_to_InfoEvaluator     #852      +/-   ##
===================================================================================
+ Coverage                                            91.93%   91.95%   +0.02%     
===================================================================================
  Files                                                   90       90              
  Lines                                                12548    12544       -4     
  Branches                                             12548    12544       -4     
===================================================================================
- Hits                                                 11536    11535       -1     
+ Misses                                                 901      898       -3     
  Partials                                               111      111              

Flag	Coverage Δ
	91.95% <58.33%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Alon-Ti]

up to stylistic question.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson and @shaharsamocha7)

---

crates/prover/src/core/prover/mod.rs line 150 at r1 (raw file):

    fn extract_composition_oods_eval(&self) -> Result<SecureField, InvalidOodsSampleStructure> {
        // TODO(andrew): `[.., composition_mask, _quotients_mask]` when add quotients commitment.
        let [_traces_mask @ .., composition_mask] = &**self.sampled_values else {

Why are you binding traces_mask?

[andrewmilson]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Alon-Ti and @shaharsamocha7)

---

crates/prover/src/core/prover/mod.rs line 150 at r1 (raw file):

Previously, Alon-Ti wrote…

Why are you binding traces_mask?

I would have done _ @ .. but it errors strangely.

OHHH. Wow didn't realise you can just do .. SMH, tyty

[Alon-Ti]

Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

[shaharsamocha7]

Reviewed 3 of 9 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)