Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Add data-type attribute to replicator and bard set divs #10692

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

BobWez98
Copy link
Contributor

We would like to add some functionality based on the set handle we have in our replicators. To identify which set the visible set is in the code, we'd like to have this data-type attribute so we can select html elements with it.

@BobWez98 BobWez98 changed the title Add data-type to be able to add functionality through javascript [5.x] Add data-type to be able to add functionality through javascript Aug 23, 2024
@jasonvarga
Copy link
Member

What you committed didn't work, there was no field there. This caused an error and broke Replicator. I fixed that and also applied this to Bard.

@jasonvarga jasonvarga changed the title [5.x] Add data-type to be able to add functionality through javascript [5.x] Add data-type attribute to replicator and bard set divs Sep 5, 2024
@jasonvarga jasonvarga merged commit 56926c5 into statamic:5.x Sep 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants