[5.x] Add submitting state for confirmation modal to better visualise a running action #10699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a loader to the confirmation modal when an action is running in the background to indicate that something is going on. Before the UI did not give any feedback.
morhi
changed the title
morhi
commented
Aug 26, 2024
This reverts commit 402ab86.
# Conflicts: # resources/js/components/modals/ConfirmationModal.vue
|
Thanks @jasonvarga for polishing my PR <3 |
|
No problem! 🇵🇱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when confirming an action that is running for a few seconds it is hard to determine if something is actually happening. This made me submitting the form twice and actually trigger an error, because the action could not be run a second time.
This PR adds a nice (hopefully nice enough) loader to visualise that there is an action running in the background.
Screen.Recording.2024-08-26.at.14.58.29.mov
Also fixes in issue with the "Create Folder" action, which submitted the form twice when pressing enter on the submit button.