Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Fix CP Asset Sort After Search issue #10709

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

danielml01
Copy link
Contributor

This resolves issue #10708
In the control panel assets table view, column sort was not functioning after a search term was used. This allows searched assets to be sorted in table view.

@duncanmcclean duncanmcclean changed the title Fix CP Asset Sort After Search issue #10708 [5.x] Fix CP Asset Sort After Search issue #10708 Aug 27, 2024
@duncanmcclean duncanmcclean linked an issue Aug 27, 2024 that may be closed by this pull request
@duncanmcclean
Copy link
Member

It looks like these changes are causing a test to fail. Are you able to take a look?

@danielml01
Copy link
Contributor Author

test was expecting specific sort order of assets and my update was adding a default order to search results. I've removed the default order from my branch.

@duncanmcclean duncanmcclean changed the title [5.x] Fix CP Asset Sort After Search issue #10708 [5.x] Fix CP Asset Sort After Search issue Aug 29, 2024
@jasonvarga jasonvarga merged commit 7de6672 into statamic:5.x Sep 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset Browser: Can't sort assets when searching
3 participants