-
-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] Add field actions modals #10833
Draft
jacksleight
wants to merge
22
commits into
statamic:5.x
Choose a base branch
from
jacksleight:feature/modal-api
base: 5.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic-cms into feature/field-actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR builds upon #10352 and adds the ability to easily create confirmation/form modals from within the action run method, allowing you to prompt for user input before performing the rest of the action logic:
CleanShot.2024-09-24.at.18.33.14.mp4
The action for that looks like this:
The fields are passed to the backend to resolve a full blueprint for the form. The values are also passed to the backend for validation. The return data contains both pre-processed and raw values, as different use cases may need different types of values.
The
keepOpen
flag allows you to keep the modal and it's busy state visible after it's confirmed. This is useful if you then need to perform other long-running tasks and want to show some feedback to the user. Without it the modal just closes as normal on confirm.Todo