feat: add `array/base/take-map` #1349

vr-varad · 2024-02-22T13:32:51Z

Closes: #1321

Description

What is the purpose of this pull request?

This pull request:

Adds @stdlib/array/base/take-map.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

…elop

vr-varad · 2024-02-22T16:37:21Z

cc @Planeshifter

README.md

kgryte · 2024-02-22T21:20:01Z

@vr-varad Would you mind updating your OP to use our GitHub PR template?

kgryte

This PR needs to be updated before we can review.

vr-varad · 2024-02-23T12:21:05Z

@kgryte any changes needed??

vr-varad · 2024-02-23T15:51:10Z

All tests are running succesfully. @Planeshifter

vr-varad · 2024-02-23T20:56:09Z

@kgryte I have made some necessary changes to the document, and I would greatly appreciate it if you could take the time to review it.

lib/node_modules/@stdlib/array/base/map2d/package.json

lib/node_modules/@stdlib/array/base/take-map/README.md

kgryte · 2024-02-25T11:08:50Z

@vr-varad I won't get to it tonight, but I will try and take another look at it tomorrow.

vr-varad · 2024-02-25T11:10:05Z

No problem now can I work on another issue @kgryte

Pranavchiku

There are minor changes that needs to be made, once addressed this PR will be good to review.

lib/node_modules/@stdlib/array/base/take-map/README.md

lib/node_modules/@stdlib/array/base/take-map/docs/repl.txt

lib/node_modules/@stdlib/array/base/take-map/test/test.assign.js

lib/node_modules/@stdlib/array/base/take-map/test/test.js

lib/node_modules/@stdlib/array/base/take-map/test/test.main.js

lib/node_modules/@stdlib/array/base/take/lib/main.js

lib/node_modules/@stdlib/array/base/take/package.json

vr-varad · 2024-02-26T10:39:45Z

@Pranavchiku i did all the changes suggested

vr-varad · 2024-02-27T06:07:29Z

@kgryte @Pranavchiku any more changes to be done? Or ready to merge

Pranavchiku · 2024-02-27T06:09:58Z

I'll review it in a while, we appreciate your contribution, thank you!

vr-varad · 2024-02-27T14:15:18Z

@Pranavchiku can i work on another issue??

Pranavchiku

@vr-varad please address previous comments, there are a lot pending. I request you to prioritise quality of PRs over number of merged.

lib/node_modules/@stdlib/array/base/take-map/README.md

lib/node_modules/@stdlib/array/base/take-map/benchmark/benchmark.assign.length.js

lib/node_modules/@stdlib/array/base/take-map/benchmark/benchmark.length.js

lib/node_modules/@stdlib/array/base/take-map/README.md

lib/node_modules/@stdlib/array/base/take-map/lib/assign.js

vr-varad · 2024-02-27T18:24:20Z

sorry @Pranavchiku I will keep that in mind, I thought that all issues were resolved sorry once again can u please approve the workflow. Sorry once again

vr-varad · 2024-02-28T13:45:42Z

@Pranavchiku can u review this are there any issue to resolve

vr-varad · 2024-02-29T21:21:18Z

@kgryte @Pranavchiku @Planeshifter any updates on reviews??

vr-varad · 2024-03-02T16:26:33Z

@kgryte @Pranavchiku @Planeshifter any updates on reviews ?? actually I am interested in contributing more so could i do it??

Planeshifter

Looked through the latest code on the PR and left a few more comments. This should be getting close to be ready for merging though. Thanks for hanging in there and persisting!

lib/node_modules/@stdlib/array/base/take-map/README.md

lib/node_modules/@stdlib/array/base/take/package.json

lib/node_modules/@stdlib/array/base/take-map/package.json

lib/node_modules/@stdlib/array/base/take-map/test/test.assign.js

lib/node_modules/@stdlib/array/base/take-map/docs/repl.txt

lib/node_modules/@stdlib/array/base/take-map/docs/types/index.d.ts

lib/node_modules/@stdlib/array/base/take-map/docs/types/test.ts

lib/node_modules/@stdlib/array/base/take-map/test/test.assign.js

vr-varad · 2024-03-02T21:38:06Z

@Planeshifter I have made the necessary changes I would like it to get reviewed @Pranavchiku @kgryte
and Please approve the workflows

vr-varad · 2024-03-06T04:08:10Z

hey @kgryte @Planeshifter @Pranavchiku
Just wanted to give you a heads up – my first PR is in review. Any chance I can dive into another issue while waiting? Excited to keep the momentum going!

lib/node_modules/@stdlib/array/base/take-map/README.md

lib/node_modules/@stdlib/array/base/take-map/docs/repl.txt

lib/node_modules/@stdlib/array/base/take-map/docs/types/test.ts

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter · 2024-03-06T15:26:07Z

@vr-varad Did one more review, sorry for the delay. This should now be ready to merge. Thank you!

Feel free to work on other issues; would love to see you continue contributing to stdlib! 🚀

PR-URL: stdlib-js#1349 Closes: stdlib-js#1321 --------- Signed-off-by: Philipp Burckhardt <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Athan Reines <[email protected]> Reviewed-by: Pranav Goswami <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>

vr-varad added 5 commits February 22, 2024 01:11

Added new example for namespace packages

199641d

Added take-map and added namespace new examples

dd5797f

Added take-map and added namespace new examples

2190f7f

Merge branch 'develop' of https://github.com/vr-varad/stdlib into dev…

3a60341

…elop

Added take-map and added namespace new examples

51ab57e

This was referenced Feb 22, 2024

[RFC]: add @stdlib/array/base/take-map #1321

Closed

[RFC]: improve README examples in namespace packages #1329

Closed

kgryte reviewed Feb 22, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

kgryte requested changes Feb 22, 2024

View reviewed changes

Added new newspace examples

7a45086

vr-varad changed the title ~~Added take-map functionality and added namespace exmaples.~~ Added namespace exmaples. Feb 23, 2024

vr-varad requested a review from kgryte February 23, 2024 03:58

added new feature@stdlib/array/base/take-map

7214304

vr-varad changed the title ~~Added namespace exmaples.~~ Added @stdlib/array/base/take. Feb 23, 2024

vr-varad changed the title ~~Added @stdlib/array/base/take.~~ Added @stdlib/array/base/take-map. Feb 23, 2024

All test ok

7e69c54

kgryte changed the title ~~Added @stdlib/array/base/take-map.~~ feat: array/base/take-map Feb 24, 2024

kgryte added Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities. labels Feb 24, 2024

kgryte reviewed Feb 24, 2024

View reviewed changes

lib/node_modules/@stdlib/array/base/map2d/package.json Outdated Show resolved Hide resolved

kgryte reviewed Feb 24, 2024

View reviewed changes

lib/node_modules/@stdlib/array/base/take-map/README.md Outdated Show resolved Hide resolved

kgryte reviewed Feb 24, 2024

View reviewed changes

lib/node_modules/@stdlib/array/base/take-map/README.md Outdated Show resolved Hide resolved

kgryte changed the title ~~feat: array/base/take-map~~ feat: add array/base/take-map Feb 24, 2024

made changes

862542a

vr-varad requested a review from kgryte February 24, 2024 03:21

vr-varad requested a review from Pranavchiku February 25, 2024 17:10

Pranavchiku requested changes Feb 26, 2024

View reviewed changes

Pranavchiku mentioned this pull request Feb 26, 2024

[RFC]: add @stdlib/string/to-well-formed #1066

Closed

3 tasks

fix: added new clbks

2a0c8d9

vr-varad requested a review from Pranavchiku February 26, 2024 11:08

Pranavchiku requested changes Feb 27, 2024

View reviewed changes

fix: resolved changes

ef66eab

vr-varad requested a review from Pranavchiku February 28, 2024 03:50

Planeshifter requested changes Mar 2, 2024

View reviewed changes

fix: made some changes

d9079fa

vr-varad requested a review from Planeshifter March 3, 2024 05:55

Planeshifter reviewed Mar 6, 2024

View reviewed changes

Apply suggestions from code review

e2aeb12

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter merged commit 0bc38ac into stdlib-js:develop Mar 6, 2024
7 checks passed

Planeshifter removed the Needs Review A pull request which needs code review. label Mar 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add `array/base/take-map` #1349

feat: add `array/base/take-map` #1349

vr-varad commented Feb 22, 2024 •

edited by kgryte

Loading

vr-varad commented Feb 22, 2024

kgryte commented Feb 22, 2024

kgryte left a comment

vr-varad commented Feb 23, 2024

vr-varad commented Feb 23, 2024 •

edited

Loading

vr-varad commented Feb 23, 2024

kgryte commented Feb 25, 2024

vr-varad commented Feb 25, 2024 •

edited

Loading

Pranavchiku left a comment

vr-varad commented Feb 26, 2024

vr-varad commented Feb 27, 2024 •

edited

Loading

Pranavchiku commented Feb 27, 2024

vr-varad commented Feb 27, 2024

Pranavchiku left a comment

vr-varad commented Feb 27, 2024

vr-varad commented Feb 28, 2024

vr-varad commented Feb 29, 2024

vr-varad commented Mar 2, 2024

Planeshifter left a comment

vr-varad commented Mar 2, 2024

vr-varad commented Mar 6, 2024

Planeshifter commented Mar 6, 2024

feat: add array/base/take-map #1349

feat: add array/base/take-map #1349

Conversation

vr-varad commented Feb 22, 2024 • edited by kgryte Loading

Description

Questions

Other

Checklist

vr-varad commented Feb 22, 2024

kgryte commented Feb 22, 2024

kgryte left a comment

Choose a reason for hiding this comment

vr-varad commented Feb 23, 2024

vr-varad commented Feb 23, 2024 • edited Loading

vr-varad commented Feb 23, 2024

kgryte commented Feb 25, 2024

vr-varad commented Feb 25, 2024 • edited Loading

Pranavchiku left a comment

Choose a reason for hiding this comment

vr-varad commented Feb 26, 2024

vr-varad commented Feb 27, 2024 • edited Loading

Pranavchiku commented Feb 27, 2024

vr-varad commented Feb 27, 2024

Pranavchiku left a comment

Choose a reason for hiding this comment

vr-varad commented Feb 27, 2024

vr-varad commented Feb 28, 2024

vr-varad commented Feb 29, 2024

vr-varad commented Mar 2, 2024

Planeshifter left a comment

Choose a reason for hiding this comment

vr-varad commented Mar 2, 2024

vr-varad commented Mar 6, 2024

Planeshifter commented Mar 6, 2024

feat: add `array/base/take-map` #1349

feat: add `array/base/take-map` #1349

vr-varad commented Feb 22, 2024 •

edited by kgryte

Loading

vr-varad commented Feb 23, 2024 •

edited

Loading

vr-varad commented Feb 25, 2024 •

edited

Loading

vr-varad commented Feb 27, 2024 •

edited

Loading