Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update namespace TypeScript declarations #1351

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

stdlib-bot
Copy link
Contributor

This PR

  • updates namespace TypeScript declarations

@stdlib-bot stdlib-bot added automated-pr Automated pull request (e.g., from a bot). Documentation Improvements, additions, or changes to documentation. labels Feb 22, 2024
@stdlib-bot stdlib-bot requested a review from a team February 22, 2024 21:35
@@ -489,7 +489,7 @@ interface Namespace {
empty: typeof empty;

/**
* Creates an uninitialized array having the same length and data type as a provided input array.
* Creates an uninitialized array having the same length as a provided input array.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Planeshifter Looks like we lost part of the description in 819d2e4, as, by default, we do infer the data type from the input array.

@@ -1040,7 +1031,7 @@ interface Namespace {
ones: typeof ones;

/**
* Creates an array filled with ones and having the same length and data type as a provided input array.
* Creates an array filled with ones and having the same length as a provided input array.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment.

@@ -1892,7 +1874,7 @@ interface Namespace {
zeros: typeof zeros;

/**
* Creates a zero-filled array having the same length and data type as a provided input array.
* Creates a zero-filled array having the same length as a provided input array.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR can move forward; however, we should investigate whether we can update the descriptions of the *-like exports to reflect that the output array data type is, by default, inferred from the input array.

@kgryte
Copy link
Member

kgryte commented Feb 22, 2024

I'll wait for CI to finish before merging.

@kgryte kgryte merged commit 8887063 into develop Feb 22, 2024
7 checks passed
@kgryte kgryte deleted the update-namespace-declarations branch February 22, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-pr Automated pull request (e.g., from a bot). Documentation Improvements, additions, or changes to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants