Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update blas/ext/base/dapxsumors to follow current project conventions #1993

Merged
merged 27 commits into from
Mar 24, 2024
Merged

refactor: update blas/ext/base/dapxsumors to follow current project conventions #1993

merged 27 commits into from
Mar 24, 2024

Conversation

ShivamAhir
Copy link
Contributor

Resolves # .

Description

update blas/ext/base/dapxsumors to follow current project conventions #1468

This pull request:

  • a
  • b
  • c

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 22, 2024
@Planeshifter Planeshifter changed the title update blas/ext/base/dapxsumors to follow current project conventions #1468 update blas/ext/base/dapxsumors to follow current project conventions #1468 Mar 23, 2024
@ShivamAhir ShivamAhir changed the title update blas/ext/base/dapxsumors to follow current project conventions #1468 update blas/ext/base/dapxsumors to follow current project conventions Mar 23, 2024
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 23, 2024
Planeshifter
Planeshifter requested changes Mar 23, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Left a bunch of requested changes that should hopefully be easy to resolve.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 23, 2024
@Planeshifter Planeshifter changed the title update blas/ext/base/dapxsumors to follow current project conventions refactor: update blas/ext/base/dapxsumors to follow current project conventions Mar 24, 2024
@Planeshifter
style: add extra empty line
e9ed858 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
style: fix indentation
585b66b 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
style: add extra empty line
26f0ffe 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
docs: update example
48f5f8b 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 24, 2024
Planeshifter
Planeshifter approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will merge shortly after CI has passed.

@Planeshifter Planeshifter merged commit 8729504 into stdlib-js:develop Mar 24, 2024
8 checks passed
@ShivamAhir
Copy link
Contributor Author

@Planeshifter grateful for your ongoing guidance and support. Hard to manage without it.😊

@ShivamAhir ShivamAhir mentioned this pull request Mar 25, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dapxsumors to follow current project conventions
3 participants
@ShivamAhir @Planeshifter @stdlib-bot