Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ndarray/base/mskfilter #2604

Draft
wants to merge 36 commits into
base: develop
Choose a base branch
from
Draft

feat: add ndarray/base/mskfilter #2604

wants to merge 36 commits into from

Conversation

Jaysukh-409
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • This PR will add ndarray/base/mskfilter.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Jul 30, 2024
@kgryte
Copy link
Member

kgryte commented Aug 7, 2024

@Jaysukh-409 You should go ahead and fix the lint failures so that CI can start passing.

kgryte
kgryte reviewed Aug 20, 2024
View reviewed changes
lib/node_modules/@stdlib/ndarray/base/mskfilter/README.md Show resolved Hide resolved
lib/node_modules/@stdlib/ndarray/base/mskfilter/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/ndarray/base/mskfilter/README.md Show resolved Hide resolved
lib/node_modules/@stdlib/ndarray/base/mskfilter/README.md
var shape = [ 5, 2 ];
var x = {
'dtype': 'float64',
'data': filledarrayBy( N, 'float64', discreteUniform( -100, 100 ) ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use random/array/discrete-uniform, random/array/bernoulli, and array/zeros for creating the array buffers.

lib/node_modules/@stdlib/ndarray/base/mskfilter/README.md Show resolved Hide resolved
lib/node_modules/@stdlib/ndarray/base/mskfilter/docs/repl.txt Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/ndarray/base/mskfilter/docs/repl.txt Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/ndarray/base/mskfilter/docs/types/index.d.ts Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/ndarray/base/mskfilter/docs/types/index.d.ts Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/ndarray/base/mskfilter/docs/types/index.d.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaysukh-409 @kgryte