Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add LL_D in math/base/napi/binary #2726

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Aug 1, 2024

Description

What is the purpose of this pull request?

This pull request:

  • adds the function napi_value stdlib_math_base_napi_ll_d( napi_env env, napi_callback_info info, double (*fcn)( double, int64_t, int64_t ) ) in math/base/napi/binary.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Aug 1, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Aug 1, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @gunjjoshi!

Would you mind submitting a follow-up PR fixing the missing includes in the int32 examples? Thanks!

@gunjjoshi
Copy link
Member Author

LGTM. Thanks, @gunjjoshi!

Would you mind submitting a follow-up PR fixing the missing includes in the int32 examples? Thanks!

@kgryte Sure, I'll make the PR.

@kgryte kgryte merged commit 46cda32 into stdlib-js:develop Aug 1, 2024
9 checks passed
@kgryte
Copy link
Member

kgryte commented Aug 1, 2024

@gunjjoshi Looks like some of the README examples are also missing stdint includes.

@gunjjoshi
Copy link
Member Author

@gunjjoshi Looks like some of the README examples are also missing stdint includes.

@kgryte I'll update them as well, thanks for the update.

kgryte added a commit that referenced this pull request Aug 1, 2024
PR-URL: #2728
Ref: #2726 (review)
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
PR-URL: stdlib-js#2726
Ref: stdlib-js#2206
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
PR-URL: stdlib-js#2728
Ref: stdlib-js#2726 (review)
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants