Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add blas/base/dtrsv #2753

Merged
merged 4 commits into from
Aug 12, 2024
Merged

feat: add blas/base/dtrsv #2753

merged 4 commits into from
Aug 12, 2024

Conversation

aman-095
Copy link
Member

@aman-095 aman-095 commented Aug 6, 2024

Progresses #2039.

Description

What is the purpose of this pull request?

This RFC proposes to add a routine to solve one of the systems of equations A*x = b or A^T*x = b as defined in BLAS Level 2 routines. Specifically adding @stdlib/blas/base/dtrsv is proposed.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Aug 6, 2024
@kgryte
Copy link
Member

kgryte commented Aug 7, 2024

@aman-095 Would you mind porting any relevant changes from #2752 to this PR? Thanks!

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. Feature Issue or pull request for adding a new feature. labels Aug 7, 2024
@kgryte
Copy link
Member

kgryte commented Aug 7, 2024

...and also, if you could add a small note, as in de0e5b9.

@kgryte kgryte added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Aug 8, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @aman-095!

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Aug 12, 2024
@kgryte kgryte merged commit 09afa7c into stdlib-js:develop Aug 12, 2024
11 checks passed
gunjjoshi pushed a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants