feat: add lapack/base/dtrti2
#2754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pranavchiku
added
Feature
|
The latest commit considers |
kgryte
reviewed
Sep 17, 2024
| if ( upper ) { | ||
| for ( j = 0; j < N; j++ ) { | ||
| if ( nounit ) { | ||
| A[ offsetA + ( j * strideA1 ) + ( j * strideA2 ) ] = 1.0 / A[ offsetA + ( j * strideA1 ) + ( j * strideA2 ) ]; |
kgryte
reviewed
Sep 17, 2024
| } | ||
| }); | ||
|
|
||
| tape( 'the function correctly computes inverse of upper triangular non-unit matrix ( row-major )', function test( t ) { |
There was a problem hiding this comment.
Suggested change
| tape( 'the function correctly computes inverse of upper triangular non-unit matrix ( row-major )', function test( t ) { | |
| tape( 'the function correctly computes inverse of upper triangular non-unit matrix (row-major)', function test( t ) { |
Remove spaces here and in other test descriptions.
kgryte
reviewed
Sep 17, 2024
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the function correctly computes inverse of lower triangular non-unit rectangular matrix ( row-major )', function test( t ) { |
There was a problem hiding this comment.
In your descriptions, parameterize to help distinguish. For example, row-major, lower, non-unit. Applies here and elsewhere.
kgryte
reviewed
Sep 17, 2024
| } | ||
| }); | ||
|
|
||
| tape( 'the function supports accessing elements from non-contiguous alignment of row and column ( row-major )', function test( t ) { |
There was a problem hiding this comment.
Refactor to include more systematic tests. Test to the interface, not the implementation.
kgryte
added
the
Needs Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2464.
Description
This pull request adds JS implementation for
lapack/base/dtrti2Related Issues
NA
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers