feat: add lapack/base/dlaqge
#2759
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pranavchiku
added
Feature
Pranavchiku
commented
Aug 8, 2024
| } | ||
|
|
||
| thresh = 0.1; | ||
| small = 1.0020841800044864E-292; |
There was a problem hiding this comment.
Suggested change
| small = 1.0020841800044864E-292; | |
| // TODO: use `dlamch( 'S' ) / dlamch( 'P' )` once it is merged. | |
| small = 1.0020841800044864E-292; |
kgryte
reviewed
Aug 12, 2024
| - **sc**: stride length for `C`. | ||
| - **oc**: starting index of `C`. | ||
| - **rc**: ratio of the smallest to the largest row scale factor. | ||
| - **cc**: ratio of the smallest to the largest column scale factor. |
kgryte
reviewed
Aug 12, 2024
| return 'N'; | ||
| } | ||
|
|
||
| if ( isRowMajor( [ strideA1, strideA2 ] ) ) { |
There was a problem hiding this comment.
Given that A is MxN, you also need to swap the loop limits when performing loop interchange. It isn't enough to simply swap the strides.
There was a problem hiding this comment.
I do not remember what I did. IIRC the code is already optimized, sa0 was used internally for both row-major and column-major and thus I removed code duplication.
kgryte
added
the
Needs Changes
|
Now that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2464.
Description
This pull request adds JS implementation for
lapack/base/dlaqge.Related Issues
NA
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers