Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add constants/lapack/dsafmin #2859

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat: add constants/lapack/dsafmin #2859

wants to merge 2 commits into from

Conversation

Pranavchiku
Copy link
Member

Towards #2464.

Description

What is the purpose of this pull request?

This pull request adds macro for constant dsafmin.

Related Issues

Does this pull request have any related issues?

NA

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. C Issue involves or relates to C. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). constants Issue or pull request specific to constants namespace labels Sep 3, 2024
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Sep 3, 2024
@Planeshifter Planeshifter self-requested a review September 3, 2024 22:06
Planeshifter
Planeshifter requested changes Sep 6, 2024
View reviewed changes
lib/node_modules/@stdlib/constants/lapack/dsafmin/README.md

#### FLOAT64_LAPACK_SAFE_MIN

The minimum [safe][safe] [double-precision floating-point][ieee754] integer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the description should be changed here and elsewhere to e.g.

Suggested change
The minimum [safe][safe] [double-precision floating-point][ieee754] integer.
The smallest positive [safe][safe] [double-precision floating-point][ieee754] number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
C Issue involves or relates to C. constants Issue or pull request specific to constants namespace Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Review A pull request which needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pranavchiku @Planeshifter