-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: updated blas/ext/base/ssort2sh
to follow current project conventions
#2957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
added
the
BLAS
Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).
label
Sep 28, 2024
@Planeshifter Ready for review!! |
Planeshifter
added
Ready To Merge
A pull request which is ready to be merged.
and removed
Needs Review
A pull request which needs code review.
labels
Sep 29, 2024
PR Commit Message
Please review the above commit message and make any necessary adjustments. |
@aayush0325 Thanks, looks great! Only updated indentation, where for *.c files, we want to consistently use TAB-indentation, whereas we use two spaces for JSON files, and line wrapping in the Will merge shortly after CI has cleared. |
Planeshifter
approved these changes
Sep 29, 2024
I'll keep that in mind for further issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BLAS
Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).
Ready To Merge
A pull request which is ready to be merged.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1536 .
Description
This pull request:
blas/ext/base/ssort2sh
to follow current project conventionsblas/ext/base/ssort2sh
to follow current project conventions #1536Related Issues
This pull request:
blas/ext/base/ssort2sh
to follow current project conventions #1536Questions
No.
Other
Checklist
@stdlib-js/reviewers