use filter_var for skip config (#60)

sunspikes · Sep 19, 2022 · 3f98bd0 · 3f98bd0
1 parent 7a765fa
commit 3f98bd0
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/ClamavValidator/ClamavValidator.php b/src/ClamavValidator/ClamavValidator.php
@@ -45,7 +45,7 @@ public function __construct(
      */
     public function validateClamav(string $attribute, $value, array $parameters): bool
     {
-        if (true === Config::get('clamav.skip_validation')) {
+        if (filter_var(Config::get('clamav.skip_validation'), FILTER_VALIDATE_BOOLEAN)) { 
             return true;
         }
 

diff --git a/tests/ClamavValidatorTest.php b/tests/ClamavValidatorTest.php
@@ -87,6 +87,20 @@ public function testValidatesSkipped()
         $this->assertTrue($validator->passes());
     }
 
+    public function testValidatesSkippedForBoolValidatedConfigValues()
+    {
+        $this->setConfig(['skip' => '1']);
+
+        $validator = new ClamavValidator(
+            $this->translator,
+            $this->clean_data,
+            ['file' => 'clamav'],
+            $this->messages
+        );
+
+        $this->assertTrue($validator->passes());
+    }
+
     public function testValidatesClean()
     {
         $this->setConfig();