Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipes for symfonycasts/sass-bundle #1278

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

makraz
Copy link

@makraz makraz commented Jan 1, 2024

Q A
License MIT
Doc issue/PR symfony/symfony-docs#...

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) January 1, 2024 14:49
Copy link

github-actions bot commented Jan 1, 2024

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1278/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1278/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'symfonycasts/sass-bundle:^0.5'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

auto-merge was automatically disabled January 1, 2024 18:15

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) January 1, 2024 18:15
@fabpot
Copy link
Member

fabpot commented Jan 18, 2024

@weaverryan Can you review this one please?

@rosier
Copy link
Contributor

rosier commented Feb 8, 2024

It looks like there is a space in the path of symfonycasts/sass-bundle/0.4/assets /styles/app.scss at the end of assets.

Is that intended?

auto-merge was automatically disabled February 8, 2024 18:19

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) February 8, 2024 18:20
@makraz
Copy link
Author

makraz commented Feb 8, 2024

It looks like there is a space in the path of symfonycasts/sass-bundle/0.4/assets /styles/app.scss at the end of assets.

Is that intended?

good catch, thank you, I fixed it 👍🏼

auto-merge was automatically disabled February 8, 2024 18:32

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) February 8, 2024 18:32
auto-merge was automatically disabled February 8, 2024 18:36

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) February 8, 2024 18:37
auto-merge was automatically disabled February 8, 2024 18:41

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) February 8, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants