test: enhance test suite for array distinction

tada5hi · May 19, 2023 · 99aa15c · 99aa15c
1 parent d11ebdd
commit 99aa15c
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 6 deletions.
diff --git a/src/utils/check.ts b/src/utils/check.ts
@@ -45,15 +45,13 @@ export function isEqual(x: any, y: any): boolean {
 
     const keysX = Reflect.ownKeys(x) as string[];
     const keysY = Reflect.ownKeys(y) as string[];
-    if (keysX.length !== keysY.length) return false;
+    if (keysX.length !== keysY.length) {
+        return false;
+    }
 
     for (let i = 0; i < keysX.length; i++) {
         const key = keysX[i];
-        if (!Reflect.has(y, key)) {
-            return false;
-        }
-
-        if (!isEqual(x[key], y[key])) {
+        if (!Reflect.has(y, key) || !isEqual(x[key], y[key])) {
             return false;
         }
     }

diff --git a/test/unit/utils/array.spec.ts b/test/unit/utils/array.spec.ts
@@ -20,11 +20,24 @@ describe('src/utils/array', function () {
 
         expect(distinctArray(arr)).toEqual([{ foo: 'bar' }]);
 
+        arr = [{foo: 'bar'}, {foo: 'baz'}]
+        expect(distinctArray(arr)).toEqual(arr);
+
         let circ : any = {foo: 'bar'};
         circ.bar = circ;
 
         arr = [{foo: { bar: 'baz'}}, circ];
         expect(distinctArray(arr)).toEqual(arr);
+
+        let now = Date.now();
+        let firstDate = new Date(now);
+        let secondData = new Date(now);
+
+        expect(distinctArray([firstDate, secondData])).toEqual([firstDate]);
+
+        let firstRegex = new RegExp(/foo/);
+        let secondRegex = new RegExp(/foo/);
+        expect(distinctArray([firstRegex, secondRegex])).toEqual([firstRegex]);
     })
 
     it('should merge arrays', () => {