Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(taiko-client): updates for protocol preconfirmation changes #17690

Merged
merged 49 commits into from
Jul 16, 2024

Conversation

davidtaikocha
Copy link
Member

No description provided.

Copy link

openzeppelin-code bot commented Jul 2, 2024

feat(taiko-client): updates for protocol preconfirmation changes

Generated at commit: b2516f6b02d3db10496158d3a781d961e2897352

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
8
42
54
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@YoGhurt111
Copy link
Contributor

After removing require(!_config.checkEOAForCalldataDA || msg.sender != tx.origin, "not EOA"); this check, all unit tests passed.

@cyberhorsey cyberhorsey marked this pull request as ready for review July 16, 2024 16:35
@cyberhorsey cyberhorsey merged commit 0b2a987 into preconfirmations Jul 16, 2024
5 of 7 checks passed
@cyberhorsey cyberhorsey deleted the preconfirmations-taiko-client branch July 16, 2024 16:35
@cyberhorsey
Copy link
Contributor

Merging this PR into preconfirmations branch as managing contract changes on one branch and client on another is getting old!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants