Fuyu3699/update dependencies #3688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 23, 2024 12:12
Signed-off-by: Fu Yu <[email protected]>
Signed-off-by: Fu Yu <[email protected]>
Signed-off-by: Fu Yu <[email protected]>
FuYu3699
force-pushed
the
fuyu3699/update-dependencies
branch
from
ece9fb0
to
531c157
Compare
FuYu3699
added
the
ok to test
github-actions
bot
removed
the
ok to test
thallgren
approved these changes
Sep 26, 2024
pkg/vif/testdata/router/go.mod
Outdated
| k8s.io/apimachinery v0.31.0 // indirect | ||
| k8s.io/cli-runtime v0.31.0 // indirect | ||
| k8s.io/client-go v0.31.0 // indirect | ||
| gvisor.dev/gvisor v0.0.0-20240919205252-49310d92b103 // indirect |
There was a problem hiding this comment.
Not sure if you know, but the gvisor component is a bit special. It requires that you pull the go branch in order to build correctly. So please use:
go get -u gvisor.dev/gvisor@go
when updating this unless you already did so.
The latest version is currently v0.0.0-20240925185045-e364897eab6a.
There was a problem hiding this comment.
Thanks @thallgren , I did not know this, and I ran into issues when update so I had to revert gvisor and containerd updates. Tried it again following your suffusion, it works now.
Signed-off-by: Fu Yu <[email protected]>
FuYu3699
force-pushed
the
fuyu3699/update-dependencies
branch
from
839d898
to
bda59e4
Compare
FuYu3699
added
the
ok to test
github-actions
bot
removed
the
ok to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few sentences describing the overall goals of the pull request's commits.
Checklist
./CHANGELOG.yml.CONTRIBUTING.mdwith any special dev tricks I had to use to work on this code efficiently.TELEMETRY.mdif I added, changed, or removed a metric name.