Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bunyan-formatter and just use json formatting from subscriber #5

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

nhudson
Copy link
Contributor

@nhudson nhudson commented Jan 5, 2024

This is to help reduce the amount of logs exported from application using this crate when distributed tracing is enabled.

before: This exposes all spans in log format

{"v":0,"name":"cp-webserver","msg":"[HTTP REQUEST - START]","level":30,"hostname":"bluebeetle","pid":638924,"time":"2024-01-05T22:21:36.616792622Z","target":"tembo_telemetry","line":187,"file":"/home/nhudson/code/tembo/tembo-telemetry/src/lib.rs"}
{"v":0,"name":"cp-webserver","msg":"[GET_ALL - START]","level":30,"hostname":"bluebeetle","pid":638924,"time":"2024-01-05T22:21:36.707171562Z","target":"cp_webserver::routes::instance","line":46,"file":"cp-webserver/src/routes/instance.rs"}
{"v":0,"name":"cp-webserver","msg":"[AUTH_REQUEST - START]","level":30,"hostname":"bluebeetle","pid":638924,"time":"2024-01-05T22:21:36.707219141Z","target":"cp_webserver::auth","line":69,"file":"cp-webserver/src/auth.rs"}
{"v":0,"name":"cp-webserver","msg":"[AUTH_REQUEST - END]","level":30,"hostname":"bluebeetle","pid":638924,"time":"2024-01-05T22:21:36.707337635Z","target":"cp_webserver::auth","line":69,"file":"cp-webserver/src/auth.rs"}
{"v":0,"name":"cp-webserver","msg":"[CHECK_INPUT - START]","level":30,"hostname":"bluebeetle","pid":638924,"time":"2024-01-05T22:21:36.707374319Z","target":"cp_webserver::db","line":31,"file":"cp-webserver/src/db.rs"}
{"v":0,"name":"cp-webserver","msg":"[CHECK_INPUT - END]","level":30,"hostname":"bluebeetle","pid":638924,"time":"2024-01-05T22:21:36.707391411Z","target":"cp_webserver::db","line":31,"file":"cp-webserver/src/db.rs"}
{"v":0,"name":"cp-webserver","msg":"[GET_ALL - END]","level":30,"hostname":"bluebeetle","pid":638924,"time":"2024-01-05T22:21:36.710214753Z","target":"cp_webserver::routes::instance","line":46,"file":"cp-webserver/src/routes/instance.rs"}
{"v":0,"name":"cp-webserver","msg":"127.0.0.1 \"GET /api/v1/orgs/org_2WjOcQXiQohBqOfwY9AL76SvYoV/instances HTTP/1.1\" 200 2 \"-\" \"curl/8.5.0\" 0.093368","level":30,"hostname":"bluebeetle","pid":638924,"time":"2024-01-05T22:21:36.71041165Z","target":"log","line":null,"file":null,"log.file":"/home/nhudson/.cargo/registry/src/index.crates.io-6f17d22bba15001f/actix-web-4.4.0/src/middleware/logger.rs","log.line":420,"log.target":"actix_web::middleware::logger","log.module_path":"actix_web::middleware::logger"}
{"v":0,"name":"cp-webserver","msg":"[HTTP REQUEST - END]","level":30,"hostname":"bluebeetle","pid":638924,"time":"2024-01-05T22:21:36.710443718Z","target":"tembo_telemetry","line":187,"file":"/home/nhudson/code/tembo/tembo-telemetry/src/lib.rs"}

after:

{"timestamp":"2024-01-05T23:04:03.430461Z","level":"INFO","fields":{"message":"127.0.0.1 \"GET /api/v1/orgs/org_2WjOcQXiQohBqOfwY9AL76SvYoV/instances HTTP/1.1\" 200 2 \"-\" \"curl/8.5.0\" 0.104515","log.target":"actix_web::middleware::logger","log.module_path":"actix_web::middleware::logger","log.file":"/home/nhudson/.cargo/registry/src/index.crates.io-6f17d22bba15001f/actix-web-4.4.0/src/middleware/logger.rs","log.line":420},"target":"actix_web::middleware::logger"}

Copy link

@sjmiller609 sjmiller609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@nhudson nhudson merged commit e005d50 into main Jan 5, 2024
5 checks passed
@nhudson nhudson deleted the nhudson/fix_excessive_logging branch January 5, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants