Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move codec-server and grpc-proxy to own module #325

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Move codec-server and grpc-proxy to own module. This will let us decouple most of our samples dependencies from the sever dependencies.

@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review January 21, 2024 05:12
@Quinn-With-Two-Ns
Copy link
Contributor Author

closes #237

codec-server/codec-server/codec-server Outdated Show resolved Hide resolved
github.com/google/uuid v1.5.0
go.temporal.io/api v1.26.0
go.temporal.io/sdk v1.25.1
go.temporal.io/server v1.22.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the codec server sample should have to depend on the server library at all (other SDKs get along fine without it, though they don't have OIDC, but surely we can copy stuff). But I understand if now is not the time you want to remove this dependency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I would rather do any changes like that in a separate PR

@Quinn-With-Two-Ns Quinn-With-Two-Ns force-pushed the seprate-modules branch 2 times, most recently from f5cae38 to 867dd8f Compare January 22, 2024 16:35
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 315c616 into temporalio:main Jan 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants