Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

searchattribute: quote name in error messages #6509

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ikonst
Copy link

@ikonst ikonst commented Sep 12, 2024

What changed?

Quote the name to clarify it's not part of the prose.

Why?

I've got this response from the service, and it took me a while to grok that 'method' was in fact the name of my search attribute:

{
  "code": 3,
  "details": "search attribute method is not defined",
  "metadata": {
    "content-type": [
      "application/grpc"
    ]
  }
}

How did you test it?

I'm terrible.

Potential risks

Someone parsing those error messages?

@ikonst ikonst requested a review from a team as a code owner September 12, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant