Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and fix typos #178

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ThexXTURBOXx
Copy link
Contributor

@ThexXTURBOXx ThexXTURBOXx commented Oct 9, 2023

This PR updates flutter_secure_storage and flutter_web_auth_2 without breaking changes for the user.
Also, all the new parameters for flutter_web_auth_2 are supported now.

If you want to use these changes right now, you can specify the following dependency_override inside your pubspec.yaml:

dependency_overrides:
  oauth2_client:
    git:
      url: https://github.com/ThexXTURBOXx/oauth2_client.git

Fixes #172
Closes #173
Closes #176
Closes #177

@codecov-commenter
Copy link

Codecov Report

Merging #178 (407baa6) into master (36f7e70) will not change coverage.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #178   +/-   ##
=======================================
  Coverage   88.34%   88.34%           
=======================================
  Files          11       11           
  Lines         446      446           
=======================================
  Hits          394      394           
  Misses         52       52           
Files Coverage Δ
lib/src/io_web_auth.dart 25.00% <0.00%> (ø)

@ThexXTURBOXx
Copy link
Contributor Author

I have also bumped the SDK constraints and fixed more typos now :)

@natebgurutech
Copy link

I ran into an issue getting this package to work on Windows, I found after attaching the debugger in Visual Studio to the running process that a .cpp file in flutter_secure_storage was aborting and crashing the app.

I overrode the dependency in pubspec.yaml to the latest version of flutter_secure_storage like so:

dependency_overrides:
  flutter_secure_storage: 9.0.0

and it fixed the issue.

I see that this pull request also has this fix. Is it possible to get it pulled into the main repo?

@ThexXTURBOXx
Copy link
Contributor Author

ThexXTURBOXx commented Oct 27, 2023

@natebgurutech If you want to use my fork, you can also use it directly like this until this PR is merged and properly published:

dependency_overrides:
  oauth2_client:
    git:
      url: https://github.com/ThexXTURBOXx/oauth2_client.git

pubspec.yaml Outdated Show resolved Hide resolved
@btrautmann
Copy link

@okrad any chance we can get this merged?

@btrautmann
Copy link

My comment above can be ignored 😅 I ended up writing my own client in combination with UrlLauncher that achieves the same but has way more graceful handling of errors, etc. than oauth2_client. Appreciate this PR though as I've used it for the past 6 months or so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies
5 participants