S3: exporting minio client #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suraj Patil <[email protected]>
saswatamcode
approved these changes
Sep 30, 2024
|
I dont think this is good library design, the particular S3 client to use is an implementation detail here - this library offers no utility except configuration for this usecase. Why would one not just use minio directly instead of having a dependency on objstore. I would prefer if we revert this PR |
patilsuraj767
added a commit
to patilsuraj767/objstore
that referenced
this pull request
Oct 1, 2024
Merged
patilsuraj767
added a commit
to patilsuraj767/objstore
that referenced
this pull request
Oct 1, 2024
Signed-off-by: Suraj Patil <[email protected]>
saswatamcode
pushed a commit
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing minio client so that it can be used for accessing other methods of minio client library. One of the use case is for generating presigned URLs.