Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only register fetched_bytes metrics for Get/GetRange #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

simonswine
Copy link
Contributor

The other operations are not exposing the fetched bytes.

@simonswine simonswine force-pushed the 20230727_only-register-fetched-bytes-get-getrange branch from 662f306 to 4e6bf23 Compare July 27, 2023 09:19
@simonswine simonswine marked this pull request as ready for review July 27, 2023 11:22
The other operations are not exposing the fetched bytes.

Signed-off-by: Christian Simon <[email protected]>
@simonswine simonswine force-pushed the 20230727_only-register-fetched-bytes-get-getrange branch from 4e6bf23 to 25a6c5a Compare July 27, 2023 12:09
Copy link
Contributor

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one suggestion

Comment on lines +459 to +462
for _, op := range []string{
OpGet,
OpGetRange,
} {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we simply put this into the other loop below with transferred bytes or do we need the extra loop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants