Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise PC regression #408

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Optimise PC regression #408

wants to merge 19 commits into from

Conversation

mumichae
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 97.61905% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 59.00%. Comparing base (9c5a936) to head (344fb75).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
+ Coverage   54.60%   59.00%   +4.39%     
==========================================
  Files          22       22              
  Lines        1683     1705      +22     
==========================================
+ Hits          919     1006      +87     
+ Misses        764      699      -65     
Flag Coverage Δ
unittests 59.00% <97.61%> (+4.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scib/metrics/cell_cycle.py 89.58% <100.00%> (+0.22%) ⬆️
scib/preprocessing.py 18.95% <100.00%> (ø)
scib/metrics/pcr.py 91.11% <97.05%> (+9.95%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Collaborator

@VladimirShitov VladimirShitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks super nice. Sometimes, the code is unclear. I left some comments on potential improvements :)

scib/metrics/pcr.py Outdated Show resolved Hide resolved
scib/metrics/pcr.py Show resolved Hide resolved
scib/metrics/pcr.py Show resolved Hide resolved
tests/metrics/test_pcr_metrics.py Show resolved Hide resolved
Copy link
Collaborator

@VladimirShitov VladimirShitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants