Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While at it... #290

Merged
merged 3 commits into from
Aug 1, 2024
Merged

While at it... #290

merged 3 commits into from
Aug 1, 2024

Conversation

federicomarini
Copy link
Contributor

I fixed the typos I could find over the different chapters.

Hope you take this as a sign of admiration for a massive resource from a Korinthenkacker like me 😉

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Zethson
Copy link
Member

Zethson commented Aug 1, 2024

Awesome! Please keep them coming - we're very grateful for any help!

@Zethson Zethson merged commit e45ea77 into theislab:master Aug 1, 2024
9 of 19 checks passed
@federicomarini
Copy link
Contributor Author

I would dare to say I am through.

Some background on how I did this.

list.files(".", pattern = ".ipynb$", recursive = TRUE) |> lapply(rmarkdown::convert_ipynb)
list.files(".", pattern = "Rmd$", recursive = T) |> lapply(spelling::spell_check_files)

... then editing in the ipynb files directly, checking what was returned there as candidates for mis-spelled words.

spell_check_files does not play too nice with the ipynb directly...

Obvious note: I did not enter the US vs UK spelling debate 🗡️ 🗡️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants