Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit-changed-pkgs: Take message as argument #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hololeap
Copy link

@hololeap hololeap commented Mar 6, 2023

Instead of keeping the message in a file, take the message as an argument.

Automatically prepends *: to the message.

Instead of keeping the message in a file, take the message as an argument.

Automatically prepends '*: ' to the message.
@thesamesam
Copy link
Owner

How does this work if I want to write something with multiple lines?

@hololeap
Copy link
Author

hololeap commented Mar 8, 2023

How does this work if I want to write something with multiple lines?

I didn't think of that possibility. I'll go ahead and close this.

@hololeap hololeap closed this Mar 8, 2023
@thesamesam
Copy link
Owner

I don't think you need to. If we pass in additional arguments to git (pkgdev passes any unknown args to git), it might work, or we can file a bug for pkgdev asking it to allow template-then-append if it doesn't already?

@hololeap hololeap reopened this Mar 8, 2023
@hololeap
Copy link
Author

Here's another QoL issue we might want to do something about:

@hololeap
Copy link
Author

Another pain point:

list=$(git diff --name-only | grep -v "/layout/" | grep -v "/metadata/")

git diff --name-only does not list untracked files, so the script doesn't work for committing brand new packages. Perhaps that wasn't the script's original purpose, but it seems like a similar enough use case for the script to support it.

This command lists untracked directories, fwiw:

git ls-files --others --directory --exclude-standard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants