lib.sh,hijack.sh: restore ability to be sourced interactively #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$SCRIPT_NAME is `-bash` when sourcing `lib.sh` directly from an interactive shell. Fixes this error in that case: ``` basename: invalid option -- 'b' Try 'basename --help' for more information. ``` Signed-off-by: Marc Herbert <[email protected]>
Run start_test() and func_exit_handler() only in "normal" usage, not when sourced interactively (for interactive debug) and not as a subtest. With this commit it's not possible to do this without any side-effect: ``` ( source case-lib/lib.sh ) ``` More to the point, it's now possible to run this and start interactive testing without any unwanted actions: ``` source case-lib/lib.sh get_firmware_path ``` Signed-off-by: Marc Herbert <[email protected]>
|
All PM-related tests fail in https://sof-ci.01.org/softestpr/PR1071/build516/devicetest/index.html is failing because of (complex?) regression thesofproject/sof#7875 One isolated suspend/resume failure in https://sof-ci.01.org/softestpr/PR1071/build517/devicetest/index.html Everything else is green. |
|
Need to test this with SubTests more. |
|
Too complex and not flexible enough: we want some scripts not to call start_test() at all. See #1170 and friends. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
start_test()andfunc_exit_handler()only in "normal" usage, notwhen sourced interactively (for interactive debug) and not as a subtest.
With this commit it's not possible to do this without any side-effect:
More to the point, it's now possible to run this and start interactive
testing without any unwanted actions: