Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sof-kernel-log-check: ignore i915 firmware loading error #1104

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

fredoh9
Copy link
Collaborator

@fredoh9 fredoh9 commented Sep 11, 2023

Filter out below errors:
[ 8196.630952] kernel: i915 0000:00:02.0: [drm] ERROR GT0: GuC initialization failed -ENXIO
[ 8196.630953] kernel: i915 0000:00:02.0: [drm] ERROR GT0: Enabling uc failed (-5)
[ 8196.630955] kernel: i915 0000:00:02.0: [drm] ERROR GT0: Failed to initialize GPU, declaring it wedged!

Link: thesofproject/linux#4530

cc:

@fredoh9 fredoh9 requested a review from a team as a code owner September 11, 2023 19:06
@fredoh9 fredoh9 requested a review from marc-hb October 18, 2023 19:22
@fredoh9
Copy link
Collaborator Author

fredoh9 commented Oct 18, 2023

@marc-hb @kv2019i I think this is very low risk PR. Any comment?

@marc-hb
Copy link
Collaborator

marc-hb commented Oct 18, 2023

"declaring GPU wedged!" does not sound like "low risk". It sounds more like a hard crash. If a GPU does not work then we should disable it and not try to use it, not try and let it crash and corrupt kernel data (error handling is never tested)

@kv2019i
Copy link
Contributor

kv2019i commented Oct 19, 2023

@marc-hb wrote:

"declaring GPU wedged!" does not sound like "low risk". It
sounds more like a hard crash. If a GPU does not work then we should
disable it and not try to use it, not try and let it crash and corrupt kernel data

While the error message is quit scary, I think the wedged state is fairly well defined and the driver is expected to continue to provide other services (it would panic otherwise). Given we don't really depend on the GPU parts, I think we can ignore this on specific DUTs.

kv2019i
kv2019i previously approved these changes Oct 19, 2023
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this to the adl|adl-s) section below. It already has similar rules.

@keqiaozhang
Copy link
Contributor

SOFCI TEST

@marc-hb
Copy link
Collaborator

marc-hb commented Nov 2, 2023

@keqiaozhang your last SOFCI TEST did not work, the page still points at 2023-09-11 results:
https://sof-ci.01.org/softestpr/PR1104/build719/devicetest/index.html
https://sof-ci.01.org/softestpr/PR1104/build721/devicetest/index.html
https://sof-ci.01.org/softestpr/PR1104/build720/devicetest/index.html

This is probably related to more recent #1123 and others not having any jenkins results at all.

EDIT: internal issue 525
EDIT2: tests are actually running but the new results are not published.

Filter out below errors:
[ 8196.630952] kernel: i915 0000:00:02.0: [drm] *ERROR* GT0: GuC initialization failed -ENXIO
[ 8196.630953] kernel: i915 0000:00:02.0: [drm] *ERROR* GT0: Enabling uc failed (-5)
[ 8196.630955] kernel: i915 0000:00:02.0: [drm] *ERROR* GT0: Failed to initialize GPU, declaring it wedged!

Link: thesofproject#1048

Signed-off-by: Fred Oh <[email protected]>
@fredoh9 fredoh9 force-pushed the fix/ignore_i915_loading_error branch from c4d59a4 to 2df1d61 Compare November 28, 2023 19:02
@fredoh9
Copy link
Collaborator Author

fredoh9 commented Nov 28, 2023

SOFCI TEST

@keqiaozhang
Copy link
Contributor

SOFCI TEST

@fredoh9 fredoh9 merged commit 6498498 into thesofproject:main Dec 1, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants