Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kmod: sof_remove: add dependencies between platforms #1133

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

plbossart
Copy link
Member

With thesofproject/linux#4703, TGL and ICL depend on CNL, and LNL on MTL. The order in which the modules are removed needs to respect those dependencies.

Link: https://sof-ci.01.org/linuxpr/PR4703/build611/devicetest/index.html

With thesofproject/linux#4703, TGL and ICL
depend on CNL, and LNL on MTL. The order in which the modules are
removed needs to respect those dependencies.

Link: https://sof-ci.01.org/linuxpr/PR4703/build611/devicetest/index.html
Signed-off-by: Pierre-Louis Bossart <[email protected]>
@plbossart plbossart requested a review from a team as a code owner November 30, 2023 18:58
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm the order did not matter in the past?

In other words, no backwards compatibility issue?

@plbossart
Copy link
Member Author

plbossart commented Nov 30, 2023

Can you confirm the order did not matter in the past?

In other words, no backwards compatibility issue?

yes, the dependency is added by a set of Kconfig select additions which did not exist before.

@plbossart plbossart merged commit 2504bd6 into thesofproject:main Nov 30, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants