tools: sof_perf_analyzer: change module CPC calculation #1136
Conversation
|
Is this basically hiding very short audio glitches? https://bravenewgeek.com/everything-you-know-about-latency-is-wrong/ |
@marc-hb ， I am not able to open this link, could you stick to this PR itself? does above link related with this PR? |
There was a problem hiding this comment.
code looks good, let's revise commit message a little bit:
In daily performance test, we have a high and abnormal peak
cycle for some module, recently, we find this abnormal peak
cycle is caused by IRQ.
Previously, module CPC is calculated by multiplying the mean
value of cpu_peak with a margin scalar. With further team
discussion based on the new finding, an agreement is reached
to use the product of module average cycle and a margin as
module CPC.
btian1
force-pushed
the
change_cpc_calculation
branch
from
43bb8b8
to
247247b
Compare
I'm not sure about the copyright sorry. I never had any problem loading that page.
Yes, it explains that averages are generally useless. Even more useless in "real-time" situation like audio . |
btian1
force-pushed
the
change_cpc_calculation
branch
from
247247b
to
22fdfec
Compare
Can we have at lease one team member that agrees with this method review this pull request? |
|
@lgirdwood has agreed to use average cycles with a fix ratio for CPC to upstream in FW manifest. So that we can use CPC in FW manifest to monitor potential performance regression in daily performance test in the future. So the method in this PR 'CPC = AVG(module) * CPC_MARGIN' with CPC_MARGIN =1.5 looks good to me. @aiChaoSONG @marc-hb |
In daily performance test, we have a high and abnormal peak cycle for some module, recently, we find this abnormal peak cycle is caused by IRQ. Previously, module CPC is calculated by multiplying the mean value of cpu_peak with a margin scalar. With further team discussion based on the new finding, an agreement is reached to use the product of module average cycle and a margin as module CPC. Signed-off-by: Baofeng Tian <[email protected]>
|
Failure not related |
Previously, module CPC is calculated by multiplying the mean value of cpu_peak with a margin scalar, however, abnormal peak cycles are finally proved that it is caused by IRQ, with further team discussion, an agreement was reached to use module average multiplied with a margin as new way for CPC calculation.