test-socwatch.sh: no need to load socwatch module manually #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-hb
requested changes
Jan 31, 2024
There was a problem hiding this comment.
Please don't delete all the corresponding code. We are barely getting started in this area which means things will change in the future and we may need this again soon.
In fact it should be very easy to make the module loading and unload optional with just this:
- sudo "$SOCWATCH_PATH"/drivers/insmod-socwatch -q
+ sudo "$SOCWATCH_PATH"/drivers/insmod-socwatch -q || true- check_socwatch_module_loaded || die "socwatch module not loaded"
+ check_socwatch_module_loaded || dlogi "socwatch module not loaded"
keqiaozhang
force-pushed
the
socwatch-update
branch
from
cf6c2f5
to
5ec7437
Compare
marc-hb
previously approved these changes
Feb 1, 2024
| } | ||
|
|
||
| socwatch_test_once() | ||
| { | ||
| local i="$1" | ||
| dlogi "===== Loop($i/$loop_count) =====" | ||
| dlogi "SoCWatch version: ${SOCWATCH_VERSION}" |
There was a problem hiding this comment.
I think you could have just run the command here but no big deal.
We only use socwatch tool to read the power data for power measurement in this case, we can directly use the latest released version, so there is no need to pre-compile the driver. Signed-off-by: Keqiao Zhang <[email protected]>
keqiaozhang
force-pushed
the
socwatch-update
branch
from
5ec7437
to
8013d14
Compare
marc-hb
approved these changes
Feb 1, 2024
|
@fredoh9 can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only use socwatch tool to read the power data for power measurement in this case, we can directly use the latest released version, so there is no need to pre-compile the driver.