Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-sof-logger.sh Predicate LDC search on !zephyr #1217

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

andyross
Copy link
Contributor

@andyross andyross commented Jul 9, 2024

[I haven't completely figured out how this script runs in CI, so this patch is mostly thrown up blind for review. But this is where the error in CI is coming from, I believe]

Zephyr builds don't produce .ldc files anymore, don't look for them and fail.

Fixes: #1216

Zephyr builds don't produce .ldc files anymore, don't look for them
and fail.

Fixes: thesofproject#1216

Signed-off-by: Andy Ross <[email protected]>
@andyross andyross requested a review from a team as a code owner July 9, 2024 01:19
@andyross
Copy link
Contributor Author

andyross commented Jul 9, 2024

Can't add reviewers. @marc-hb @kv2019i @dbaluta and whoever else is bumping into this on their PRs will want to take a look.

Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test results look good!

Thanks a lot, I was afraid it would be more complicated (this script is very convoluted in other places) but this seems enough, great!

@marc-hb marc-hb merged commit 5f25449 into thesofproject:main Jul 9, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] PR test fail to .ldc file not found!
2 participants